Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.23-compatible range iterators as an experiment #1020

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Jul 17, 2024

No description provided.

@flimzy flimzy force-pushed the range branch 4 times, most recently from 2768257 to 67009d2 Compare July 18, 2024 07:35
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.

Project coverage is 62.97%. Comparing base (daafdfe) to head (1c88e97).
Report is 2 commits behind head on master.

Files Patch % Lines
resultset.go 0.00% 33 Missing ⚠️
changes.go 0.00% 17 Missing ⚠️
attachments.go 0.00% 9 Missing ⚠️
updates.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
- Coverage   63.20%   62.97%   -0.23%     
==========================================
  Files         286      286              
  Lines       18889    18957      +68     
==========================================
  Hits        11938    11938              
- Misses       6416     6484      +68     
  Partials      535      535              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy force-pushed the range branch 2 times, most recently from 13374cf to 1c88e97 Compare July 18, 2024 09:01
@flimzy flimzy merged commit f8de882 into master Jul 18, 2024
1 of 3 checks passed
@flimzy flimzy deleted the range branch July 18, 2024 09:32
@flan6
Copy link

flan6 commented Aug 15, 2024

Sorry for commenting it here, but I just read your article about the range-over-func topic that go 1.23 just released and I wanted to ask. Not a fan of sub tests? Didnt meant to be invasive, just curious of your opinion about go subtests. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants