-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GirTool, Integration folders and props files #995
Conversation
kashifsoofi
commented
Jan 8, 2024
- I agree that my contribution may be licensed either under MIT or any version of LGPL license.
Thank you for your contribution 👍 Some comments:
<Import Project="../../Properties/GirCore.Tooling.props" />
<Import Project="../../Properties/GirCore.Logging.props" />
<Import Project="../../Properties/GirCore.Libraries.props" />
<Import Project="../../Properties/GirCore.Publishing.props" />
|
c3d2a97
to
601a737
Compare
I didn't have instant access to Windows machine (Visual Studio), I have now updated using Visual Studio |
Hm, for some reason the solution file is not working for me with Jetbrains Rider. The Can you copy the content into your |
1103054
to
c293305
Compare
Updated, can you please try again |
898072c
to
e964bf5
Compare
I think the solution file is fine now. Can you try to update the 2 solution filter files? I updated them (there was one project missing in them) and updated the Gist with the content is here: https://gist.github.com/badcel/a5f9544ffe39ea6bcc5ed91fe0bd0690 |
e964bf5
to
789a47d
Compare
789a47d
to
2fe7de1
Compare
Thanks the build passed, can you please check the solution file? |
Thank you for your contribution 👍 |