Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception handling #906

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Improve exception handling #906

merged 4 commits into from
Jul 25, 2023

Conversation

badcel
Copy link
Member

@badcel badcel commented Jul 23, 2023 •
edited
Loading

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

Fixes: #905

badcel added 4 commits July 23, 2023 20:02
@badcel
GException:
57f79da 
- Make GException constructor public
- Rename file to match class name
- Remove #region tags
@badcel
Remove GLib.Error.ThrowOnError method
246f830
@badcel
Improve async method handling
8086494 
- Use AsyncReadyCallbackAsyncHandler to ensure the callback is not garbage collected
- Verify source object is set before calling ...Finish method
@badcel
Async: Don't throw but set exceptions
178eeae 
This makes exceptions catchable in an async context.
@badcel badcel marked this pull request as ready for review July 25, 2023 14:56
@badcel badcel merged commit 26f90d1 into main Jul 25, 2023
@badcel badcel deleted the improve-exception-handling branch July 25, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standard implementation of Async methods is broken
1 participant
@badcel