Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to add an exception handler for unhandled exceptions #861

Merged
merged 1 commit into from
May 1, 2023

Conversation

badcel
Copy link
Member

@badcel badcel commented May 1, 2023

These unhandled exceptions would otherwise immediately terminate the program once they reach the native code boundary. An exception handler lets applications do any logging / message dialogs etc and decide whether they want to terminate the program or attempt to continue.

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

@cameronwhite I took your initial code and updated it to not use an event. I think this is a simpler approach for now.

@badcel badcel requested a review from cameronwhite May 1, 2023 19:51
@badcel badcel force-pushed the feature/exception-handling2 branch from 638f10c to 6cdff2c Compare May 1, 2023 20:06
Copy link
Contributor

@cameronwhite cameronwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

These unhandled exceptions would otherwise immediately terminate the program once they reach the native code boundary. An exception handler lets applications do any logging / message dialogs etc and decide whether they want to terminate the program or attempt to continue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants