Fix nullable warnings for interface parameters. #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could generate nullable warnings from the `as` expression producing null, or from the parameter being nullable. Since interfaces inherit from the `GLib.IHandle` interface, this cast can be avoided by just using its `Handle` property. This is done inline, similar to how class parameters are converted to native parameters.
cameronwhite
force-pushed
the
fix/nullable-warning
branch
from
353cad3 to
14e1935
Compare
|
Looks good to me. Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could generate nullable warnings from the
asexpression producing null, or from the parameter being nullable. Since interfaces inherit from theGLib.IHandleinterface, this cast can be avoided by just using itsHandleproperty. This is done inline, similar to how class parameters are converted to native parameters.This reduces the number of warnings in the build from 6552 to 5792