Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable method if annotations are wrong #852

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

badcel
Copy link
Member

@badcel badcel commented Apr 12, 2023

Disable methods if they have a caller allocated out parameter with a size parameter with the direction out. The out size parameter does not make sense if the first parameter is caller allocated. In this case the size parameter must be caller allocated, too.

As this can't be fixed during render time the method is disabled completely. To fix this the gir file must be fixed upstream.

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

Disable methods if they have a caller allocated out parameter with a size parameter with the direction out. The out size parameter does not make sense if the first parameter is caller allocated. In this case the size parameter must be caller allocated, too.

As this can't be fixed during render time the method is disabled completely. To fix this the gir file must be fixed upstream.
@badcel badcel force-pushed the disable-wrongly-annotated-methods branch from 66f4159 to a63a266 Compare April 15, 2023 21:40
@badcel badcel marked this pull request as draft April 15, 2023 22:01
@badcel badcel marked this pull request as ready for review April 16, 2023 18:25
@badcel badcel merged commit 189465f into main Apr 16, 2023
@badcel badcel deleted the disable-wrongly-annotated-methods branch April 16, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant