-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate aliases #841
Generate aliases #841
Conversation
607e016
to
6e5e165
Compare
e0374e2
to
172642c
Compare
@cameronwhite Do you have remarks regarding the alias support? You can see it's features in the tests here. |
I think that looks fine to me. |
I made it implicit as constant values can't be of an alias type as creating an instance makes them not constant. So I fall back to their base type for rendering as constant. The implicit cast allows to use the constant primitive value as a parameter to a function which requires the alias struct. I wonder if it is to much "magic" as I normally don't like those implicit things happening. |
That's a good point about constants, I can see that being necessary for pattern matching if there are any aliased types with constants that are useful to compare against |
0c96a97
to
3ca7e13
Compare
There is currently only GST_CLOCK_TIME_NONE. It seems to work in a switch statement but not a switch expression. Perhaps there is a way forward to solve this. Will test. |
4a70a41
to
0978bcc
Compare
Fixes #757