Update manual Cairo bindings for string parameters #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is largely just a refactoring to make the manual bindings consistent with the generated bindings after #803, using the new string handle classes For string return values this adds some more type safety over IntPtr, and fixes a couple nullable warnings. `FontOptions.Variations` should have actually been a nullable string, while `ToyFontFace.Family` is correct to be a non-nullable string.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely just a refactoring to make the manual bindings consistent with the generated bindings after #803, using the new string handle classes
For string return values this adds some more type safety over IntPtr, and fixes a couple nullable warnings from the usage of
StringHelper.ToStringUtf8().FontOptions.Variationsshould have actually been a nullable string, whileToyFontFace.Familyis correct to be a non-nullable string.