Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null return of GObject.Value.GetString #813

Merged
merged 4 commits into from
Feb 25, 2023
Merged

Conversation

badcel
Copy link
Member

@badcel badcel commented Feb 23, 2023

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

Todo:

  • Update nugets
  • add unit test to ensure exception is thrown in case of an unexpected null string return for utf8 and platform string. Possible exception name "StringNullPointerException" / "NullPointerExcception" / "NullPointerConversionException" / NullPointerException<T> / NullHandleException
  • add doc comments to new safe handles

@badcel badcel force-pushed the fix-gobject-value-get-string branch 5 times, most recently from c3307a9 to a04c3de Compare February 25, 2023 21:30
In case of an unexpected NULL return for non nullable utf8 or platform strings a NullHandleException must be thrown. This adds the corresponding unit tests.
@badcel badcel force-pushed the fix-gobject-value-get-string branch from a04c3de to 8fb9647 Compare February 25, 2023 21:38
@badcel badcel merged commit 4cdfde7 into main Feb 25, 2023
@badcel badcel deleted the fix-gobject-value-get-string branch February 25, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant