Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary manual bindings #804

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

cameronwhite
Copy link
Contributor

With #756 these manual bindings are no longer needed. Removing the Filename bindings is also useful for #791 which will introduce changes to string marshalling

With #756 these manual bindings are no longer needed.
Removing the `Filename` bindings is also useful for #791 which will introduce changes to string marshalling
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@badcel badcel merged commit 3bdf845 into main Feb 14, 2023
@badcel badcel deleted the fix/remove-manual-bindings branch February 14, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants