GError support #798

cameronwhite · 2023-02-11T15:06:42Z

Add a throws flag to the model, replacing the manually added parameter
Generate an out ErrorOwnedHandle parameter for internal functions
For public functions, throw an exception if an error was returned
Skip properties where the getter or setter throw. We could implement this, but it only occurs in deprecated WebKit2WebExtension functions so it doesn't seem worthwhile
Handle name collisions between interface methods and constructors. This occurs for Gio.DBusConnection and a couple other classes, which have a new_finish constructor but also have a new_finish method from Gio.AsyncInitable
Remove manual bindings for Element.MakeFromUri() and Pixbuf NewFromFile() which are no longer needed.
Add tests for functions, methods, and constructors that throw

Fixes: #756

cameronwhite · 2023-02-11T19:00:44Z

I think this is working well now - one future TODO item I noticed is that callbacks can also have a throws flag (https://gitlab.gnome.org/GNOME/gobject-introspection/-/blob/main/docs/gir-1.2.rnc#L428) if they have a GError ** parameter

badcel

Looks pretty good already. Only 2 minor changes and one bigger one. But I think the bigger one improves the code a bit regarding readability and reuseablility and improves the GirModel.

src/Generation/GirModel/Constructor.cs

src/Generation/Generator/Renderer/Internal/Errors.cs

src/Native/GirTestLib/girtest-error-tester.c

src/Generation/Generator/Renderer/Internal/Error.cs

src/Generation/Generator/Renderer/Public/Class/ClassConstructors.cs

src/Generation/Generator/Renderer/Public/Error.cs

src/Generation/Generator/Renderer/Public/FunctionRenderer.cs

src/Generation/Generator/Renderer/Public/MethodRenderer.cs

src/Generation/GirModel/Callable.cs

…meter. - Introduce a 'Callable' interface, which is a common base for constructors, methods and functions. This matches the schema and will make it easier to write more reusable code in the generator.

- Internal functions take an `out ErrorOwnedHandle` parameter, which maps to `GError **` for the native function - Public functions don't expose this parameter, but instead throw an exception if an error was produced. - Skip properties where the getter or setter throw. This only occurs in deprecated WebKit2WebExtension functions. - Remove manual bindings for Element.MakeFromUri() and Pixbuf NewFromFile() which are no longer needed. Fixes: #756

This occurs for Gio.DBusConnection, which has a new_finish constructor but also has a new_finish method from Gio.AsyncInitable

cameronwhite · 2023-02-12T16:25:22Z

Thanks! Updated with the latest changes

cameronwhite force-pushed the feature/gerror branch 3 times, most recently from a878a7c to bc7a90e Compare February 11, 2023 18:30

cameronwhite marked this pull request as ready for review February 11, 2023 19:00

badcel reviewed Feb 11, 2023

View reviewed changes

src/Generation/GirModel/Constructor.cs Outdated Show resolved Hide resolved

src/Generation/Generator/Renderer/Internal/Errors.cs Outdated Show resolved Hide resolved

src/Native/GirTestLib/girtest-error-tester.c Outdated Show resolved Hide resolved

cameronwhite force-pushed the feature/gerror branch 4 times, most recently from 86c7041 to aa7e4a7 Compare February 12, 2023 05:33