-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a C test library for easier testing of the generated bindings #764
Conversation
I did not look at the code but the idea is very welcome! Edit: I like how you separated the new stuff from the old. I would not like to require a C toolchain for dotnet developers. I updated #504 with a new idea. |
1d36d5b
to
7023e1c
Compare
I've got the Windows build sorted out now, so this is building and running the test successfully on all platforms 🎉 |
Can you update the reademe's Build section and include a Additionally I think it would be helpful to explain why the solution filter exists. |
b6051a2
to
a137b27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, very well done. This helps a lot to establish a much improved testability of the generator it is very much appreciated.
Please fix the remaining (minor) remarks and it is good to go.
This will hopefully make it easier to have more extensive tests for correctness, which can run without a display and without requiring a lot of boilerplate code (e.g. constructing a GTK application and widgets) Related to #504
a137b27
to
1f113a5
Compare
Thanks! I've pushed fixes for those issues |
This is related to #504 - I decided to experiment with this after writing a C library to test out #763, and found it really useful to have a simple C function (which I could also add printouts to, etc) to test against
I think this could make it easier to have more extensive tests for correctness, which can run without a display and without requiring a lot of boilerplate code to call a function with the parameter type we want to test (e.g. having to construct a GTK application and widgets)
Still a work in progress, but wanted to get some initial feedback on whether this would be worth adding?
Also a couple questions:
Libs
folder like everything else, but it could perhaps go elsewhere. I'm not sure if there are any things to watch out for with this, e.g. would it be pulled into the Nuget packages?TODOs