Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incomplete manual binding for TimeoutAddFull #760

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Conversation

cameronwhite
Copy link
Contributor

Now that global functions are generated, this is available as GLib.Functions.TimeoutAddFull() (the generated version works fine in my testing).

GtkSharp had a similar GLib.Timeout class so I stumbled across this while porting Pinta, and then found it didn't work :)

Now that global functions are generated, this is available as `GLib.Functions.TimeoutAddFull()`.
@cameronwhite
Copy link
Contributor Author

Somewhat related, I noticed that https://docs.gtk.org/glib/func.timeout_add_full.html mentions This method is renamed to [g_timeout_add()](https://docs.gtk.org/glib/func.timeout_add.html) in language bindings.
So perhaps the shadows property is what indicates it should be renamed to TimeoutAdd?

@badcel
Copy link
Member

badcel commented Jan 14, 2023

Oh very interesting catch. This is used for method overloading which is not yet implemented. See #761

@badcel badcel merged commit 740477d into main Jan 14, 2023
@badcel badcel deleted the fix/remove-timeout branch January 14, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants