GObject.Object: Make "Dispose" method virtual again #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The virtual keyword got lost by accident during the implementation of the new instantiation framework. Custom classes want to be able to plug into the "Dispose" call of GObject.Object otherwise the custom "Dispose" would eventually not be executed if the method is marked with the "new" keyword.
badcel
force-pushed
the
object-restore-virtual-dispose-method
branch
from
f565094 to
6c67561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual keyword got lost by accident during the implementation of the new instantiation framework. Custom classes want to be able to plug into the "Dispose" call of GObject.Object otherwise the custom "Dispose" would eventually not be executed if the method is marked with the "new" keyword.