Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rendering code for repositories only required via includes #1086

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

adamreeve
Copy link
Contributor

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

This fixes #1084

I couldn't see a good way to test this change, it would probably need a separate GitHub action job to generate code for a subset of the libraries which seems pretty heavy handed, but let me know if you think that's necessary or there's a better way.

@badcel
Copy link
Member

badcel commented Jun 27, 2024

In regard to your code changes in GirTool I found nothing to improve, great work :-).

Looking at the code after some pretty long time I don't like what I did there originally. It is a little bit to hard to grasp what is happening for my feeling. But it is like it is. Perhaps it will see some improvements over time.

Please remove the GModule-2.0.gir from the list of generated projects in GenerateLibs.fsx, it is currently not needed. (Just remove your last commit to avoid adding an additional commit.)

After this change the PR is good to go.

@adamreeve adamreeve force-pushed the disable_include_generation branch from 0eba32e to 3c20006 Compare June 28, 2024 01:35
@adamreeve
Copy link
Contributor Author

OK thanks, I've removed the GModule-2.0.gir project now.

@badcel badcel merged commit 829eaa7 into gircore:main Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip code generation for repositories that were pulled in as includes
2 participants