Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate semicolon in return statements #1068

Merged
merged 1 commit into from
May 30, 2024

Conversation

adamreeve
Copy link
Contributor

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

This is a minor tidy up to the generated code. Some of the expressions returned from ReturnTypeConverter implementations added a semicolon, but a semicolon is already added everywhere ReturnTypeToManagedExpression.Render is called.

This didn't cause any build failures but Rider would show red lines when viewing the generated code and complain about "unreachable code", referring to the empty statement before the second semicolon.

@badcel badcel merged commit fbc6ce4 into gircore:main May 30, 2024
3 checks passed
@badcel
Copy link
Member

badcel commented May 30, 2024

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants