Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve long handling 2 #1067

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Improve long handling 2 #1067

merged 3 commits into from
Jun 7, 2024

Conversation

badcel
Copy link
Member

@badcel badcel commented May 29, 2024

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

Fixes: #1066

@badcel badcel force-pushed the improve-long-handling-2 branch 7 times, most recently from 9f93788 to ac1217d Compare June 1, 2024 18:50
@badcel badcel force-pushed the improve-long-handling-2 branch 3 times, most recently from 57c8d76 to ff547c8 Compare June 7, 2024 15:38
badcel added 2 commits June 7, 2024 17:54
The size of long on windows is always 32 bit. On 64 bit unix systems it is 64 bit. CLong / CULong has the same behavior so it must be used to communicate with native code.
@badcel badcel force-pushed the improve-long-handling-2 branch from ff547c8 to d6fec7c Compare June 7, 2024 15:54
@badcel badcel marked this pull request as ready for review June 7, 2024 16:07
@badcel badcel merged commit 9b11472 into main Jun 7, 2024
3 checks passed
@badcel badcel deleted the improve-long-handling-2 branch June 7, 2024 16:07
badcel added a commit that referenced this pull request Sep 25, 2024
GirModel.CLong is 32 bit on all windows platforms, 32 bit on 32 bit unix platforms and 64 bit on 64bit unix platforms. GirModel.Long ist 64 bit on all platforms.

This reverts the changes from #1067 and only adds the CLong / CULong handling for "glong" / "gulong". All other long types stay like originally intended.

Fixes #1098
badcel added a commit that referenced this pull request Sep 26, 2024
GirModel.CLong is 32 bit on all windows platforms, 32 bit on 32 bit unix platforms and 64 bit on 64bit unix platforms. GirModel.Long ist 64 bit on all platforms.

This reverts the changes from #1067 and only adds the CLong / CULong handling for "glong" / "gulong". All other long types stay like originally intended.

Fixes #1098
badcel added a commit that referenced this pull request Sep 26, 2024
GirModel.CLong is 32 bit on all windows platforms, 32 bit on 32 bit unix platforms and 64 bit on 64bit unix platforms. GirModel.Long ist 64 bit on all platforms.

This reverts the changes from #1067 and only adds the CLong / CULong handling for "glong" / "gulong". All other long types stay like originally intended.

Fixes #1098
badcel added a commit that referenced this pull request Sep 26, 2024
GirModel.CLong is 32 bit on all windows platforms, 32 bit on 32 bit unix platforms and 64 bit on 64bit unix platforms. GirModel.Long ist 64 bit on all platforms.

This reverts the changes from #1067 and only adds the CLong / CULong handling for "glong" / "gulong". All other long types stay like originally intended.

Fixes #1098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long: Wrong size on windows
1 participant