SYCL: Remove misleading ggml_sycl_op_flatten function #12387
+506
−604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
qnixsynapse
commented
Mar 14, 2025
| // dd = data device | ||
| float * src0_ddf = (float *) src0->data; | ||
| float * src1_ddf = use_src1 ? (float *) src1->data : nullptr; | ||
| float * dst_ddf = (float *) dst->data; |
There was a problem hiding this comment.
This function typecasted src0, src1 and dst tensors to float regardless of whatever types they were. I think we don't want this behaviour in the long run.
There was a problem hiding this comment.
Just curious, why we don't use auto? You could avoid the casting and if the datatype changes in future, you don't have to rework it again?
Modern C++ code should use auto where ever it is possible.
There was a problem hiding this comment.
Do we need to create a separate pointer variable when we are passing the ggml_tensor itself anyways to the kernel OP function which contains everything needed to perform the OP?
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
qnixsynapse
force-pushed
the
remove_op_flatten_fn
branch
from
f42c7bb to
73f1849
Compare
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original work of #11515. Tried to submit smaller change this time.