fix: fee limits for LND and LDK, isolated balance calculation #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two isolated app (subwallet) vulnerabilities fixed in this PR:
TESTING:
11 sats:
10 sats:
LND (same as above, with polar, using
lncli updatechanpolicy --base_fee_msat 11000 --chan_point ccd6e82c4d55c0be3a6ff4622a7b213b4aa01f 7ce504b44c1dbce5b306dd5f3a:0 --fee_rate 0 --time_lock_delta 18
the payment cannot be sent, but withlncli updatechanpolicy --base_fee_msat 10000 --chan_point ccd6e82c4d55c0be3a6ff4622a7b213b4aa01f 7ce504b44c1dbce5b306dd5f3a:0 --fee_rate 0 --time_lock_delta 18
the payment can be sent)Balances: I manually edited one of my sent transactions on an isolated app to have a huge fee. I correctly see a negative balance and cannot make payments. nwc get_balance and HTTP API return correct value for negative balances.