Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ZapPlanner custom app #933

Merged
merged 18 commits into from
Jan 7, 2025
Merged

feat: ZapPlanner custom app #933

merged 18 commits into from
Jan 7, 2025

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 2, 2025

TODOs:

  • add card on home page if the user has no zapplanner apps
  • ability to provide an optional name and message through dialog
  • create subscription via api and save subscription ID to the app metadata
  • change to sat pricing, not fiat
  • review method of app detail page interacting with zapplanner (should this be proxied through alby hub rather than adding a CSRF exception?)

image

@rolznz rolznz requested a review from reneaaron January 2, 2025 10:05
@rolznz rolznz changed the title Feat: ZapPlanner custom app feat: ZapPlanner custom app Jan 2, 2025
@bumi
Copy link
Contributor

bumi commented Jan 6, 2025

that's super cool!

can we add a quick note somewhere explaining on how it works?

"ZapPlanner is a tool to securely schedule recurring payments. A new special app connection with a strict budget is created for each scheduled payment. This allows you to securely setup recurring payments and be in full control"

@rolznz
Copy link
Contributor Author

rolznz commented Jan 7, 2025

@bumi @reneaaron I will merge it as is for now.

I am not really happy with the CSRF exception here, but I discussed with Rene and this was a way to do a quick proof of concept. The other option is to proxy the API calls through the backend, but this requires some thought architecturally as it means an app detail page also requires adding routes, and then is much more complicated and possibly more in the direction of proper plugins.

image

@rolznz rolznz marked this pull request as ready for review January 7, 2025 06:39
@rolznz rolznz merged commit 03abb34 into master Jan 7, 2025
9 checks passed
@rolznz rolznz deleted the feat/zapplanner branch January 7, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants