feat: node page revamp for web and mobile #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add backend endpoint to fetch bitcoin rates show usd equivalent of balances
pavanjoshi914
changed the title
rolznz
reviewed
Jan 7, 2025
rolznz
reviewed
Jan 7, 2025
rolznz
reviewed
Jan 7, 2025
rolznz
reviewed
Jan 7, 2025
rolznz
reviewed
Jan 7, 2025
rolznz
reviewed
Jan 9, 2025
rolznz
reviewed
Jan 9, 2025
rolznz
reviewed
Jan 9, 2025
rolznz
reviewed
Jan 10, 2025
http/alby_http_service.go
Outdated
| if err != nil { | ||
| logger.Logger.WithError(err).Error("Failed to get Bitcoin rate") | ||
| return c.JSON(http.StatusInternalServerError, ErrorResponse{ | ||
| Message: fmt.Sprintf("Failed to get Bitcoin rate for currency %s: %s", "usd", err.Error()), |
There was a problem hiding this comment.
why is USD part of the error here...?
|
@pavanjoshi914 nice work, it would be cool to have the fiat values on the send/receive pages too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node page revamp for desktop and mobile
add backend endpoint to fetch bitcoin rates
show usd equivalent of balances
Part of #675