feat: add pagination to tx list #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@im-adithya what is the status of this one? |
im-adithya
commented
Feb 18, 2025
rolznz
reviewed
Feb 21, 2025
rolznz
reviewed
Feb 21, 2025
rolznz
reviewed
Feb 21, 2025
rolznz
reviewed
Feb 21, 2025
rolznz
reviewed
Feb 21, 2025
rolznz
reviewed
Feb 21, 2025
rolznz
reviewed
Feb 21, 2025
rolznz
reviewed
Feb 21, 2025
| @@ -50,7 +50,7 @@ func (controller *nip47Controller) HandleListTransactionsEvent(ctx context.Conte | |||
| transactionType = &listParams.Type | |||
| } | |||
|
|
|||
| dbTransactions, err := controller.transactionsService.ListTransactions(ctx, listParams.From, listParams.Until, limit, listParams.Offset, listParams.Unpaid || listParams.UnpaidOutgoing, listParams.Unpaid || listParams.UnpaidIncoming, transactionType, controller.lnClient, &appId, false) | |||
| dbTransactions, _, err := controller.transactionsService.ListTransactions(ctx, listParams.From, listParams.Until, limit, listParams.Offset, listParams.Unpaid || listParams.UnpaidOutgoing, listParams.Unpaid || listParams.UnpaidIncoming, transactionType, controller.lnClient, &appId, false) | |||
There was a problem hiding this comment.
would it be useful to include the total count in the response? there's no spec for it yet but I think it's a good addition
rolznz
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Needs some more testing, drafting till then