fix: allow self-signed certificates and to skip during setup #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Dec 11, 2024
|
@im-adithya nice improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
Description
EDIT: We decided that it's good to always verify if a certificate is passed by the user. If users raise concerns about using their own self-signed certificate (as it fails the verification), we'll think of adding a checkbox saying "I'm using a self signed certificate" which when checked can skip the cert verification process.
As we anyways ask the user to provide the certificate, it doesn't make any sense to verify the server certificate and host name, the same is also true for the case when the TLS certificate is not provided (as the user agrees to the risk it poses). So this adds
InsecureSkipVerify: truein both cases while generating transport credentials.(And yes, this PR also adds the possibility to continue without adding a TLS certificate)
Screenshot