Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify node page and manual open channel flows #843

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Dec 3, 2024

Partially addresses #675

  • remove extra buttons from node page
  • change default channel flow to increase receiving capacity
  • update copy on node page and manual open channel flows
  • add tooltips on new channel amounts

image

image

image

image

- remove extra buttons from node page
- change default channel flow to increase receiving capacity
- update copy on node page and manual open channel flows
- add tooltips on new channel amounts
@rolznz rolznz added this to the v1.11.0 milestone Dec 3, 2024
@rolznz rolznz requested a review from bumi December 4, 2024 07:37
@rolznz
Copy link
Contributor Author

rolznz commented Dec 4, 2024

I didn't do the new UI design updates yet, but I think these are the most critical changes for the release

@bumi
Copy link
Contributor

bumi commented Dec 4, 2024

wondering if we should add a note to this LSP channel page with some information about the channel.

Alby Hub works with selected service providers (LSPs) which provide the best network connectivity and liquidity to receive payments. The channel typically stays open as long as there is usage. You can choose your favorit LSP and also open channels manually.

@rolznz
Copy link
Contributor Author

rolznz commented Dec 5, 2024

@bumi added and a link to https://guides.getalby.com/user-guide/alby-account-and-browser-extension/alby-hub/faq-alby-hub/how-to-open-a-channel where we can add more details.
image

@rolznz rolznz merged commit c4e441a into master Dec 5, 2024
7 of 9 checks passed
@rolznz rolznz deleted the feat/simplify-node-page-and-manual-channel-flows branch December 5, 2024 03:43
@bumi
Copy link
Contributor

bumi commented Dec 5, 2024

btw. just reading the title of the page again "open a channel with lightning" 🤔

@rolznz
Copy link
Contributor Author

rolznz commented Dec 6, 2024

It should be with Lightning Payment I guess. It is a bit long CC @stackingsaunter

@bumi
Copy link
Contributor

bumi commented Dec 6, 2024

or nothing? just "Open a Channel" 🤔

@stackingsaunter
Copy link
Contributor

@bumi I wanted to clearly communicate how user will pay beforehand and differentiate other flow with the same (with on-chain).

Any other ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants