Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: disconnect alby account in auth code form #833

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Nov 28, 2024

Fixes #821

Uses the same functionality as the Alby Account settings page. This will only show for users using the default OAuth client (self-hosted hubs)

image

image

@rolznz rolznz requested a review from bumi November 28, 2024 23:10
@rolznz
Copy link
Contributor Author

rolznz commented Nov 28, 2024

@bumi is there an API we can use to check if the account is blocked? then we can also only show this button in that case (Actually, maybe it still makes sense to show it)

@bumi
Copy link
Contributor

bumi commented Nov 29, 2024

I think that's good, it gives control to the user

Copy link
Contributor

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz rolznz merged commit 6981e00 into master Nov 29, 2024
8 of 9 checks passed
@rolznz rolznz deleted the feat/auth-code-form-disconnect-alby-account branch November 29, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disconnecting from Alby Account for users in blocked countries
2 participants