Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use buzzpay new URL format #797

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: use buzzpay new URL format #797

merged 2 commits into from
Nov 13, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Nov 13, 2024

Fixes #759

name param is not read correctly and needs fixing on the PoS side.

@rolznz rolznz requested a review from bumi November 13, 2024 07:12
@bumi
Copy link
Contributor

bumi commented Nov 13, 2024

I am not sure if I can fix the query param on the POS side. maybe I ask some AI :)

should we use name or label - I think internally we call it label there.

@rolznz
Copy link
Contributor Author

rolznz commented Nov 13, 2024

@bumi added here: getAlby/pos@86363cf also to the share link: getAlby/pos@08ae31c

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@rolznz
Copy link
Contributor Author

rolznz commented Nov 13, 2024

should we use name or label - I think internally we call it label there.

It supports both, but I agree it makes more sense as label. I've updated it.

@rolznz rolznz merged commit f46f876 into master Nov 13, 2024
9 checks passed
@rolznz rolznz deleted the fix/buzzpay-url branch November 13, 2024 23:03
@bumi
Copy link
Contributor

bumi commented Nov 13, 2024

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuzzPay PoS incorrectly passes name property
2 participants