chore: show wallet pubkey on connection page #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneaaron
approved these changes
Mar 4, 2025
One client/app which knows the wallet pubkey can see activity across all clients that use the same pubkey. Although it's E2E encrypted, it still leaks metadata about what a single user has been doing. @frnandu was there another reason? |
|
Okay, but for me that's not enough to justify urging users to re-create the connection, I think it's fine the way you implemented it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not showing the wallet service pubkey anywhere which is useful info. I also added an alert to show if the app is a legacy one or not. It's not a critical issue, but I think it's nice to know and be able to see.