fix: show total channels and peers #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@im-adithya in the second screenshot, why is the peers not 1 / 2? |
|
Mentioned in the PR comment, |
|
@im-adithya sorry, I read your comment. That's weird in LND. Is there a way to get offline peers? it would be good to show those. LDK shows offline peers. |
|
I checked the LND codebase as well, sadly we can't fetch the offline peers. But one thing we can do is to calculate those from the offline channels if any and add them up, but I feel it might be unnecessary work |
|
@im-adithya that won't be perfect either since you can have peers with no channels. I guess it's ok for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1070
In LND, ListPeers only returns the list of connected peers so this fix will not make a difference there, not sure about LDK.
Channels should be fixed though.
Screenshots
On switching off a node in Polar: (Notice Peers)