Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove transfer alby hosted balance + new designs for node table #1058

Merged
merged 17 commits into from
Mar 5, 2025
Merged

remove transfer alby hosted balance + new designs for node table #1058

merged 17 commits into from
Mar 5, 2025

Conversation

pavanjoshi914
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 commented Feb 3, 2025 •
edited by rolznz
Loading

Closes #633

image

@rolznz
Copy link
Contributor

rolznz commented Feb 3, 2025

Why are we making this change? the shared wallet balance are now fee credits and can only be used for purchasing channels, right?

@pavanjoshi914
Copy link
Contributor Author

pavanjoshi914 commented Feb 3, 2025 •
edited
Loading

https://www.figma.com/design/2IyilDewDrdNP3G1NixPYd/%F0%9F%8C%93-Alby-Hub?node-id=7203-106594&m=dev

it was changed according to this it just moves alby hosted balance card into lightning card itself (if present). we have separate card for alby hosted balance before.

@pavanjoshi914 pavanjoshi914 requested a review from rolznz February 3, 2025 09:25
@pavanjoshi914 pavanjoshi914 changed the title feat: update ui for balance cards in node page remove transfer alby hosted balance Feb 4, 2025
@pavanjoshi914 pavanjoshi914 requested a review from rolznz February 11, 2025 06:19
@rolznz rolznz added this to the v1.15.0 milestone Feb 13, 2025
@pavanjoshi914
Copy link
Contributor Author

resolved conflicts

@pavanjoshi914 pavanjoshi914 changed the title remove transfer alby hosted balance remove transfer alby hosted balance + new designs for node table Feb 14, 2025
@pavanjoshi914 pavanjoshi914 requested a review from rolznz February 14, 2025 12:24
@rolznz
Copy link
Contributor

rolznz commented Feb 19, 2025

@pavanjoshi914 can you check FirstChannel.tsx - we probably need some changes there too. e.g. canMigrateFunds should be removed

im-adithya
im-adithya requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@im-adithya im-adithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This differs from the UI, maybe we can keep them in a row till sm mobile width and then shift to column?

Screenshot 2025-02-20 at 9 31 20 PM Screenshot 2025-02-20 at 9 31 31 PM

@pavanjoshi914
Copy link
Contributor Author

This differs from the UI, maybe we can keep them in a row till sm mobile width and then shift to column?

we already do that. sm prefix is upto 640px can you check again?

@rolznz
Copy link
Contributor

rolznz commented Feb 21, 2025

Is useAlbyBalance still required in useOnboardingData?

@rolznz
Copy link
Contributor

rolznz commented Mar 5, 2025

@pavanjoshi914 there are still clear inconsistencies in styling - font weights, card padding, ...

image

rolznz
rolznz approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz rolznz merged commit cf01b48 into master Mar 5, 2025
11 checks passed
@rolznz rolznz deleted the transfer-balance-card branch March 5, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-adithya im-adithya im-adithya requested changes

@rolznz rolznz rolznz approved these changes

@stackingsaunter stackingsaunter Awaiting requested review from stackingsaunter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Consistency on names and words: Alby Hosted Balance -> Alby Shared Node Balance
3 participants
@pavanjoshi914 @rolznz @im-adithya