feat: currency switcher #1050
Merged
feat: currency switcher #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pavanjoshi914
commented
Jan 31, 2025
•
pavanjoshi914
commented
rolznz
reviewed
Jan 31, 2025
| @@ -66,6 +123,32 @@ function Settings() { | |||
| </SelectContent> | |||
| </Select> | |||
| </div> | |||
| <div className="grid gap-1.5"> | |||
| <Label htmlFor="currency">Select Currency</Label> | |||
There was a problem hiding this comment.
Suggested change
| <Label htmlFor="currency">Select Currency</Label> | |
| <Label htmlFor="currency">Fiat Currency</Label> |
rolznz
reviewed
Jan 31, 2025
| @@ -66,6 +123,32 @@ function Settings() { | |||
| </SelectContent> | |||
| </Select> | |||
| </div> | |||
| <div className="grid gap-1.5"> | |||
| <Label htmlFor="currency">Select Currency</Label> | |||
| {loading ? ( | |||
There was a problem hiding this comment.
why is this conditional needed? I removed it and reloaded and still seems to work ok
rolznz
reviewed
Jan 31, 2025
http/http_service.go
Outdated
| @@ -63,7 +63,7 @@ func (httpSvc *HttpService) RegisterSharedRoutes(e *echo.Echo) { | |||
| e.Use(middleware.SecureWithConfig(middleware.SecureConfig{ | |||
| ContentTypeNosniff: "nosniff", | |||
| XFrameOptions: "DENY", | |||
| ContentSecurityPolicy: "default-src 'self'; img-src 'self' https://uploads.getalby-assets.com https://getalby.com; connect-src 'self' https://api.getalby.com https://getalby.com https://zapplanner.albylabs.com", | |||
| ContentSecurityPolicy: "default-src 'self'; img-src 'self' https://uploads.getalby-assets.com https://getalby.com; connect-src 'self' https://api.getalby.com https://getalby.com https://getalby.com https://zapplanner.albylabs.com", | |||
There was a problem hiding this comment.
getalby.com was added twice, I will remove it
rolznz
reviewed
Jan 31, 2025
http/http_service.go
Outdated
| @@ -91,6 +91,7 @@ func (httpSvc *HttpService) RegisterSharedRoutes(e *echo.Echo) { | |||
|
|
|||
| e.GET("/api/info", httpSvc.infoHandler) | |||
| e.POST("/api/setup", httpSvc.setupHandler) | |||
| e.PATCH("/api/currency", httpSvc.setCurrencyHandler) | |||
There was a problem hiding this comment.
later we could have an /api/settings instead so we don't need to add multiple routes to manage different settings. But I added a TODO for now.
There was a problem hiding this comment.
Also, this should go in the restricted group, it doesn't need to be a public endpoint
- simplify code - change api endpoint to update settings rather than just currency - add missing fiat value on receive invoice page - allow passing classname to formatted fiat component
|
@pavanjoshi914 overall nice job! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.