-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3353: Ensure user info passed in GafferPop #3354
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3354 +/- ##
=============================================
- Coverage 68.08% 68.06% -0.03%
Complexity 2596 2596
=============================================
Files 957 957
Lines 30670 30674 +4
Branches 3399 3402 +3
=============================================
- Hits 20881 20877 -4
- Misses 8304 8313 +9
+ Partials 1485 1484 -1 ☔ View full report in Codecov by Sentry. |
rest-api/spring-rest/src/main/java/uk/gov/gchq/gaffer/rest/controller/GremlinController.java
Show resolved
Hide resolved
rest-api/spring-rest/src/main/java/uk/gov/gchq/gaffer/rest/handler/GremlinWebSocketHandler.java
Show resolved
Hide resolved
|
Addresses some of the issues with passing information from the REST API to gafferpop by ensuring each request now has its own instance of the tinkerpop graph layer so the variables are unique per request. Also stops the user from being reset immediately by the custom GraphStep.
Few other minor bits of tidying and improvements to otel logging.
Related issue