Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3353: Ensure user info passed in GafferPop #3354

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Jan 17, 2025

Addresses some of the issues with passing information from the REST API to gafferpop by ensuring each request now has its own instance of the tinkerpop graph layer so the variables are unique per request. Also stops the user from being reset immediately by the custom GraphStep.

Few other minor bits of tidying and improvements to otel logging.

Related issue

@tb06904 tb06904 requested review from cn337131 and p29876 January 17, 2025 15:52
@tb06904 tb06904 linked an issue Jan 17, 2025 that may be closed by this pull request
@tb06904 tb06904 added bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 89.89899% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.06%. Comparing base (4eee4de) to head (2b911f2).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...store/operation/handler/OperationChainHandler.java 20.00% 4 Missing ⚠️
...a/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java 91.89% 3 Missing ⚠️
...q/gaffer/rest/handler/GremlinWebSocketHandler.java 87.50% 1 Missing and 1 partial ⚠️
...gchq/gaffer/rest/controller/GremlinController.java 97.05% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3354      +/-   ##
=============================================
- Coverage      68.08%   68.06%   -0.03%     
  Complexity      2596     2596              
=============================================
  Files            957      957              
  Lines          30670    30674       +4     
  Branches        3399     3402       +3     
=============================================
- Hits           20881    20877       -4     
- Misses          8304     8313       +9     
+ Partials        1485     1484       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

p29876
p29876 previously approved these changes Jan 20, 2025
cn337131
cn337131 previously approved these changes Jan 21, 2025
@tb06904 tb06904 added this to the 2.3.2 milestone Jan 21, 2025
@tb06904 tb06904 dismissed stale reviews from cn337131 and p29876 via 2b911f2 January 21, 2025 12:04
@j69772 j69772 merged commit 07694ea into develop Jan 21, 2025
29 checks passed
@j69772 j69772 deleted the gh-3353-user-info-passed-in-gafferpop branch January 21, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure user and info is passed in GafferPop
4 participants