Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3340: Misleading vertices in Gremlin #3341

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Nov 26, 2024

Fixes issue of odd number of vertices being returned if lots of edges are in the Gaffer result. This is primarily due them not being filtered out in the view as they are used in the orphaned vertex check. To fix this the orphan check has been made optional and opt in so the user should be aware of the potential side effects. Also increased default limit as it was quite low.

Related issue

@tb06904 tb06904 added bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module labels Nov 26, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Nov 26, 2024
@tb06904 tb06904 requested review from cn337131 and p29876 November 26, 2024 10:24
@tb06904 tb06904 linked an issue Nov 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.00%. Comparing base (e299ccc) to head (2f5c955).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...a/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3341      +/-   ##
=============================================
- Coverage      68.01%   68.00%   -0.01%     
  Complexity      2596     2596              
=============================================
  Files            955      954       -1     
  Lines          30564    30555       -9     
  Branches        3376     3380       +4     
=============================================
- Hits           20787    20778       -9     
  Misses          8302     8302              
  Partials        1475     1475              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wb36499 wb36499 merged commit 7726ff3 into develop Dec 2, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3340-misleading-vertices-in-gremlin branch December 2, 2024 15:54
@tb06904 tb06904 modified the milestones: 2.4.0, 2.3.2 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading vertices returned in Gremlin
4 participants