Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3326: Update Schema merge federated POC #3328

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Oct 29, 2024

Updates how schemas are merged to make them more robust to failure. Includes some minor related tweaks too.

Related issue

@tb06904 tb06904 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Oct 29, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Oct 29, 2024
@tb06904 tb06904 linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.01%. Comparing base (3aae44d) to head (e8d9fd1).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...mple/operation/handler/FederatedOutputHandler.java 33.33% 2 Missing ⚠️
...e/operation/handler/FederatedOperationHandler.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3328      +/-   ##
=============================================
+ Coverage      67.98%   68.01%   +0.02%     
  Complexity      2596     2596              
=============================================
  Files            955      955              
  Lines          30531    30564      +33     
  Branches        3371     3376       +5     
=============================================
+ Hits           20757    20787      +30     
- Misses          8299     8302       +3     
  Partials        1475     1475              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

p29876
p29876 previously approved these changes Oct 30, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wb36499 wb36499 merged commit 5655f6c into develop Oct 31, 2024
26 of 28 checks passed
@wb36499 wb36499 deleted the gh-3326-update-schema-merge-federated-poc branch October 31, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update how schemas are merged Federated POC
4 participants