Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OTEL user attribute #3321

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Change OTEL user attribute #3321

merged 2 commits into from
Oct 18, 2024

Conversation

p29876
Copy link
Member

@p29876 p29876 commented Oct 16, 2024

  • change user attribute to OTEL standard enduser.id that can be picked up by external OTEL dashboards
  • make constants for other attributes to ensure consistency

standardise other attributes
@p29876 p29876 added the tech-debt Relates to Technical Debt label Oct 16, 2024
@p29876 p29876 added this to the 2.3.1 milestone Oct 16, 2024
Copy link

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.91%. Comparing base (2b89f94) to head (ba93fcb).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...gchq/gaffer/rest/controller/GremlinController.java 57.14% 2 Missing and 1 partial ⚠️
...store/operation/handler/OperationChainHandler.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3321      +/-   ##
=============================================
- Coverage      67.91%   67.91%   -0.01%     
  Complexity      2596     2596              
=============================================
  Files            952      952              
  Lines          30469    30477       +8     
  Branches        3361     3362       +1     
=============================================
+ Hits           20692    20697       +5     
- Misses          8305     8307       +2     
- Partials        1472     1473       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wb36499 wb36499 merged commit 9bf6f1b into develop Oct 18, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the otel-user branch October 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Relates to Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants