Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3319: Fixes ability to get orphan vertices from edges #3320

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Oct 16, 2024

Fix that allows users to get the 'orphan' vertices from edges that have no associated entities.
Also change to GetSchema op when creating a view to allow use of opOperations in GafferPop.

Related issue

@cn337131 cn337131 added bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module labels Oct 16, 2024
@cn337131 cn337131 added this to the 2.3.1 milestone Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.90%. Comparing base (2b89f94) to head (f756c5e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...rpop/process/traversal/util/GafferVertexUtils.java 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3320      +/-   ##
=============================================
- Coverage      67.91%   67.90%   -0.01%     
  Complexity      2596     2596              
=============================================
  Files            952      952              
  Lines          30469    30492      +23     
  Branches        3361     3363       +2     
=============================================
+ Hits           20692    20706      +14     
- Misses          8305     8310       +5     
- Partials        1472     1476       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cn337131 cn337131 marked this pull request as ready for review October 16, 2024 13:58
Copy link

@wb36499 wb36499 merged commit a5a67ac into develop Oct 21, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3319-fix-vertices-bug-on-edges branch October 21, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GafferPop support for edges with no entities
4 participants