Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3121: MapStore only supports string visibility #3313

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

rj77259
Copy link
Member

@rj77259 rj77259 commented Oct 7, 2024

No description provided.

…s commit allows any type of object to be passed.
@rj77259 rj77259 linked an issue Oct 7, 2024 that may be closed by this pull request
@cn337131 cn337131 changed the title First commit. Fixing bug that would only allow String properties. Gh-3121: MapStore only supports string visibility Oct 8, 2024
@cn337131 cn337131 added this to the 2.3.1 milestone Oct 8, 2024
@cn337131 cn337131 added bug Confirmed or suspected bug map-store Specific to/touches the map-store module labels Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (b9e4593) to head (ef5598d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3313      +/-   ##
=============================================
+ Coverage      67.84%   67.87%   +0.02%     
- Complexity      2594     2596       +2     
=============================================
  Files            951      951              
  Lines          30372    30377       +5     
  Branches        3347     3347              
=============================================
+ Hits           20606    20617      +11     
+ Misses          8297     8293       -4     
+ Partials        1469     1467       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@wb36499 wb36499 merged commit ac9c4a7 into develop Oct 14, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the 3121-mapstore-only-supports-string-visibility branch October 14, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug map-store Specific to/touches the map-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapStore only supports string visibility
4 participants