Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3308: Specify merge classes federated POC #3311

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Oct 3, 2024

Adds ability to set the merge classes via the operation options using the same property keys as you would through the store properties.

This also added merge configuration for Map types along with, ability to add an exception list of graphs so a user can specify to run on all graphs except a defined list (this is the feature from #3224).

Related issue

@tb06904 tb06904 added federated-store Specific to/touches the federated-store module feature A proposed new feature labels Oct 3, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Oct 3, 2024
@tb06904 tb06904 requested review from cn337131, p29876 and wb36499 October 3, 2024 12:16
@tb06904 tb06904 linked an issue Oct 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (e0db908) to head (62e2ff9).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3311      +/-   ##
=============================================
+ Coverage      67.82%   67.84%   +0.02%     
- Complexity      2594     2595       +1     
=============================================
  Files            951      951              
  Lines          30353    30366      +13     
  Branches        3344     3347       +3     
=============================================
+ Hits           20586    20601      +15     
  Misses          8297     8297              
+ Partials        1470     1468       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Oct 9, 2024

Copy link

sonarqubecloud bot commented Oct 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@wb36499 wb36499 merged commit 279e60a into develop Oct 10, 2024
49 of 51 checks passed
@wb36499 wb36499 deleted the gh-3308-specify-merge-classes-federated-poc branch October 10, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to specify merge classes as operation options in Federated POC
5 participants