Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3309: Add new fed store to GafferPop testing #3310

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Oct 3, 2024

Adds simple federated store to GafferPop integration tests.

Additional update to the getAllLimit being changed to getElementsLimit so that it applies across federated graphs. Note this means that this will be applied to ALL queries, regardless of seeded/unseeded.

Couple of fixes also for the OTEL spans as lots of gremlin seeds in the explain make it too long.

Related issue

@cn337131 cn337131 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Oct 3, 2024
@cn337131 cn337131 added this to the 2.4.0 milestone Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (279e60a) to head (a0f9445).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3310   +/-   ##
==========================================
  Coverage      67.84%   67.84%           
+ Complexity      2595     2594    -1     
==========================================
  Files            951      951           
  Lines          30366    30372    +6     
  Branches        3347     3347           
==========================================
+ Hits           20601    20606    +5     
  Misses          8297     8297           
- Partials        1468     1469    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cn337131 cn337131 marked this pull request as ready for review October 4, 2024 08:33
Copy link
Member

@p29876 p29876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
can the mergers please make sure the change to GetElements limit is in the squashed commit message

Copy link

@wb36499 wb36499 merged commit b9e4593 into develop Oct 10, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3309-add-new-fed-store-to-gafferpopITs branch October 10, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add simple fed store POC to GafferPopITs
5 participants