Gh-3309: Add new fed store to GafferPop testing #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cn337131
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3310 +/- ##
==========================================
Coverage 67.84% 67.84%
+ Complexity 2595 2594 -1
==========================================
Files 951 951
Lines 30366 30372 +6
Branches 3347 3347
==========================================
+ Hits 20601 20606 +5
Misses 8297 8297
- Partials 1468 1469 +1 ☔ View full report in Codecov by Sentry. |
tb06904
reviewed
Oct 3, 2024
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopFederatedITs.java
Outdated
Show resolved
Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopFederationTests.java
Outdated
Show resolved
Hide resolved
library/tinkerpop/src/test/resources/federatedStore/simple-fed-store.properties
Show resolved
Hide resolved
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
tb06904
previously approved these changes
Oct 4, 2024
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
tb06904
approved these changes
Oct 4, 2024
p29876
approved these changes
Oct 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple federated store to GafferPop integration tests.
Additional update to the getAllLimit being changed to getElementsLimit so that it applies across federated graphs. Note this means that this will be applied to ALL queries, regardless of seeded/unseeded.
Couple of fixes also for the OTEL spans as lots of gremlin seeds in the explain make it too long.
Related issue