-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3309: Add new fed store to GafferPop testing #3310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3310 +/- ##
==========================================
Coverage 67.84% 67.84%
+ Complexity 2595 2594 -1
==========================================
Files 951 951
Lines 30366 30372 +6
Branches 3347 3347
==========================================
+ Hits 20601 20606 +5
Misses 8297 8297
- Partials 1468 1469 +1 ☔ View full report in Codecov by Sentry. |
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopFederatedITs.java
Outdated
Show resolved
Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopFederationTests.java
Outdated
Show resolved
Hide resolved
library/tinkerpop/src/test/resources/federatedStore/simple-fed-store.properties
Show resolved
Hide resolved
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can the mergers please make sure the change to GetElements limit is in the squashed commit message
|
Adds simple federated store to GafferPop integration tests.
Additional update to the getAllLimit being changed to getElementsLimit so that it applies across federated graphs. Note this means that this will be applied to ALL queries, regardless of seeded/unseeded.
Couple of fixes also for the OTEL spans as lots of gremlin seeds in the explain make it too long.
Related issue