Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3303: No error reported when Gremlin endpoint fails #3304

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Sep 26, 2024

Fixes the issue where the status was always reported as 200 on the Gremlin execute endpoints. They now fail with 500 and a message.

Some misc fixes for open telemetry spans as well.

Related issue

@tb06904 tb06904 added bug Confirmed or suspected bug rest-api Specific to/touches a part of the REST API labels Sep 26, 2024
@tb06904 tb06904 added this to the 2.3.1 milestone Sep 26, 2024
@tb06904 tb06904 linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.84%. Comparing base (5960ac1) to head (d26074d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...store/operation/handler/OperationChainHandler.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3304   +/-   ##
==========================================
  Coverage      67.83%   67.84%           
  Complexity      2595     2595           
==========================================
  Files            951      951           
  Lines          30337    30352   +15     
  Branches        3342     3343    +1     
==========================================
+ Hits           20580    20593   +13     
- Misses          8291     8292    +1     
- Partials        1466     1467    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@wb36499 wb36499 merged commit d3d494e into develop Sep 30, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3303-no-error-reported-gremlin-endpoint branch September 30, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug rest-api Specific to/touches a part of the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error reported when Gremlin endpoint query fails
3 participants