Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3291: Add GetAllGraphInfo operation to POC federated store #3298

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Sep 16, 2024

Added a GetAllGraphInfo operation to the POC simple federated store. This can easily be modified to have additional fields within the map, including auths. Operation returns key information about the configuration of the store.

Related issue

@cn337131 cn337131 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Sep 16, 2024
@cn337131 cn337131 added this to the 2.3.1 milestone Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (1099bef) to head (99acc0d).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...er/federated/simple/operation/GetAllGraphInfo.java 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3298   +/-   ##
==========================================
  Coverage      67.76%   67.76%           
  Complexity      2594     2594           
==========================================
  Files            947      949    +2     
  Lines          30217    30237   +20     
  Branches        3338     3339    +1     
==========================================
+ Hits           20476    20490   +14     
- Misses          8274     8280    +6     
  Partials        1467     1467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cn337131 cn337131 marked this pull request as ready for review September 16, 2024 15:41
wb36499
wb36499 previously approved these changes Sep 16, 2024
Copy link

@cn337131 cn337131 modified the milestones: 2.3.1, 2.4.0 Sep 18, 2024
@j69772 j69772 merged commit 4ce1ec5 into develop Sep 19, 2024
27 of 28 checks passed
@j69772 j69772 deleted the gh-3291-add-getallgraphinfo-poc-fed-store branch September 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a GetAllGraphInfo operation to POC federated store
5 participants