Gh-2840: MapStore MatchedVertex inconsistent #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cn337131
changed the title
cn337131
changed the title
cn337131
added
bug
p29876
reviewed
Sep 17, 2024
...tion/map-store/src/test/java/uk/gov/gchq/gaffer/mapstore/impl/GetAllElementsHandlerTest.java
Outdated
Show resolved
Hide resolved
p29876
reviewed
Sep 17, 2024
core/operation/src/main/java/uk/gov/gchq/gaffer/operation/data/EdgeSeed.java
Show resolved
Hide resolved
p29876
reviewed
Sep 17, 2024
...lementation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/AddElementsHandler.java
Show resolved
Hide resolved
tb06904
reviewed
Sep 17, 2024
...lementation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/AddElementsHandler.java
Show resolved
Hide resolved
...tion/map-store/src/test/java/uk/gov/gchq/gaffer/mapstore/impl/GetAllElementsHandlerTest.java
Outdated
Show resolved
Hide resolved
...tion/map-store/src/test/java/uk/gov/gchq/gaffer/mapstore/impl/GetAllElementsHandlerTest.java
Outdated
Show resolved
Hide resolved
I think the map store implementation for MatchedVertex is now correct We need to investigate the behaviour for Accumulo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3297 +/- ##
=============================================
- Coverage 67.94% 67.94% -0.01%
Complexity 2596 2596
=============================================
Files 955 955
Lines 30530 30530
Branches 3369 3369
=============================================
- Hits 20745 20744 -1
Misses 8306 8306
- Partials 1479 1480 +1 ☔ View full report in Codecov by Sentry. |
|
Ready for re-review |
cn337131
previously approved these changes
Oct 10, 2024
rj77259
previously approved these changes
Oct 18, 2024
cn337131
approved these changes
Oct 22, 2024
wb36499
approved these changes
Oct 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue