Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-2840: MapStore MatchedVertex inconsistent #3297

Merged
merged 20 commits into from
Oct 23, 2024

Conversation

j69772
Copy link
Member

@j69772 j69772 commented Sep 16, 2024

@cn337131 cn337131 changed the title Gh 2840 mapstore matchedvertex inconsistent Gh-2840: mapstore matchedvertex inconsistent Sep 16, 2024
@cn337131 cn337131 changed the title Gh-2840: mapstore matchedvertex inconsistent Gh-2840: MapStore MatchedVertex inconsistent Sep 16, 2024
@cn337131 cn337131 added bug Confirmed or suspected bug map-store Specific to/touches the map-store module labels Sep 16, 2024
@cn337131 cn337131 added this to the 2.3.1 milestone Sep 16, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (5e2b804) to head (bae522e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3297      +/-   ##
=============================================
- Coverage      67.94%   67.94%   -0.01%     
  Complexity      2596     2596              
=============================================
  Files            955      955              
  Lines          30530    30530              
  Branches        3369     3369              
=============================================
- Hits           20745    20744       -1     
  Misses          8306     8306              
- Partials        1479     1480       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p29876
Copy link
Member

p29876 commented Oct 9, 2024

Ready for re-review
Can the mergers please ensure that the squashed commit message contains a reference to #3314 for the history

cn337131
cn337131 previously approved these changes Oct 10, 2024
@rj77259 rj77259 self-requested a review October 18, 2024 14:13
rj77259
rj77259 previously approved these changes Oct 18, 2024
@p29876 p29876 dismissed stale reviews from rj77259 and cn337131 via c368c66 October 22, 2024 13:41
Copy link

@wb36499 wb36499 merged commit 73b7544 into develop Oct 23, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-2840-mapstore-matchedvertex-inconsistent branch October 23, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug map-store Specific to/touches the map-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map store GetAllElements returns matchedVertex on Edge results
7 participants