Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3290: Configure with properties in federated POC #3293

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Sep 13, 2024

Added ability to configure aspects of the simple federated store using store properties.

Related issue

@tb06904 tb06904 added federated-store Specific to/touches the federated-store module feature A proposed new feature labels Sep 13, 2024
@tb06904 tb06904 linked an issue Sep 13, 2024 that may be closed by this pull request
Copy link

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (16fd6a3) to head (be3411b).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...fer/federated/simple/FederatedStoreProperties.java 28.57% 5 Missing ⚠️
...rated/simple/merge/FederatedResultAccumulator.java 85.71% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3293      +/-   ##
=============================================
+ Coverage      67.73%   67.76%   +0.03%     
  Complexity      2594     2594              
=============================================
  Files            945      947       +2     
  Lines          30160    30217      +57     
  Branches        3329     3338       +9     
=============================================
+ Hits           20428    20476      +48     
- Misses          8267     8274       +7     
- Partials        1465     1467       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tb06904 tb06904 added this to the 2.4.0 milestone Sep 13, 2024
@wb36499 wb36499 merged commit 1099bef into develop Sep 16, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3290-store-properties-federated-poc branch September 16, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring default merging in federated POC
3 participants