Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3283: Remove Graph operation for Federated POC #3285

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Sep 10, 2024

Adds a remove graph and get all graph IDs operation to the simple federated store. The remove graph can optionally delete all data or just de reference the graph.

Related issue

@tb06904 tb06904 added federated-store Specific to/touches the federated-store module feature A proposed new feature labels Sep 10, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Sep 10, 2024
@tb06904 tb06904 linked an issue Sep 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 71.73913% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.66%. Comparing base (789a898) to head (a030eb6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...gaffer/federated/simple/operation/RemoveGraph.java 68.18% 7 Missing ⚠️
...fer/federated/simple/operation/GetAllGraphIds.java 25.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3285      +/-   ##
=============================================
+ Coverage      67.64%   67.66%   +0.01%     
+ Complexity      2595     2594       -1     
=============================================
  Files            938      942       +4     
  Lines          30024    30070      +46     
  Branches        3321     3321              
=============================================
+ Hits           20311    20346      +35     
- Misses          8251     8262      +11     
  Partials        1462     1462              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

p29876
p29876 previously approved these changes Sep 10, 2024
@p29876
Copy link
Member

p29876 commented Sep 10, 2024

🔥

tb06904 and others added 2 commits September 11, 2024 08:56
Copy link

@wb36499 wb36499 merged commit 278acd3 into develop Sep 11, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3283-remove-graph-op-federated-poc branch September 11, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add remove graph Operation to simple federated POC
4 participants