Gh-3279: AddGraph Operation for Federated POC #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tb06904
added
federated-store
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3280 +/- ##
=============================================
+ Coverage 67.59% 67.64% +0.05%
+ Complexity 2596 2594 -2
=============================================
Files 936 938 +2
Lines 29973 30024 +51
Branches 3318 3321 +3
=============================================
+ Hits 20260 20310 +50
Misses 8251 8251
- Partials 1462 1463 +1 ☔ View full report in Codecov by Sentry. |
p29876
reviewed
Sep 5, 2024
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java
Outdated
Show resolved
Hide resolved
p29876
reviewed
Sep 5, 2024
...le-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/operation/AddGraph.java
Outdated
Show resolved
Hide resolved
p29876
reviewed
Sep 5, 2024
...in/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/FederatedOperationHandler.java
Outdated
Show resolved
Hide resolved
|
p29876
approved these changes
Sep 5, 2024
rchangy
pushed a commit
to rchangy/Gaffer
that referenced
this pull request
Sep 7, 2024
* basic add graph handler * support for federated specific ops * update testing for operation * test tweaks * spotless * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
AddGraphoperation to the simple federated POC. To do this some additional logic in the operation handlers has also been added as well as, ensuring a prefix is added to any sub graphs in the federated store to avoid collisions with other instances.Related issue