-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3279: AddGraph Operation for Federated POC #3280
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3280 +/- ##
=============================================
+ Coverage 67.59% 67.64% +0.05%
+ Complexity 2596 2594 -2
=============================================
Files 936 938 +2
Lines 29973 30024 +51
Branches 3318 3321 +3
=============================================
+ Hits 20260 20310 +50
Misses 8251 8251
- Partials 1462 1463 +1 ☔ View full report in Codecov by Sentry. |
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java
Outdated
Show resolved
Hide resolved
...le-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/operation/AddGraph.java
Outdated
Show resolved
Hide resolved
...in/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/FederatedOperationHandler.java
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* basic add graph handler * support for federated specific ops * update testing for operation * test tweaks * spotless * address comments
Adds an
AddGraph
operation to the simple federated POC. To do this some additional logic in the operation handlers has also been added as well as, ensuring a prefix is added to any sub graphs in the federated store to avoid collisions with other instances.Related issue