Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3279: AddGraph Operation for Federated POC #3280

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Sep 4, 2024

Adds an AddGraph operation to the simple federated POC. To do this some additional logic in the operation handlers has also been added as well as, ensuring a prefix is added to any sub graphs in the federated store to avoid collisions with other instances.

Related issue

@tb06904 tb06904 linked an issue Sep 4, 2024 that may be closed by this pull request
@tb06904 tb06904 added federated-store Specific to/touches the federated-store module feature A proposed new feature labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (a8b0739) to head (1416f0e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...hq/gaffer/federated/simple/operation/AddGraph.java 70.37% 8 Missing ⚠️
...v/gchq/gaffer/federated/simple/FederatedStore.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3280      +/-   ##
=============================================
+ Coverage      67.59%   67.64%   +0.05%     
+ Complexity      2596     2594       -2     
=============================================
  Files            936      938       +2     
  Lines          29973    30024      +51     
  Branches        3318     3321       +3     
=============================================
+ Hits           20260    20310      +50     
  Misses          8251     8251              
- Partials        1462     1463       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Sep 5, 2024

Copy link
Member

@wb36499 wb36499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wb36499 wb36499 merged commit 789a898 into develop Sep 5, 2024
28 checks passed
@wb36499 wb36499 deleted the gh-3279-addgraph-op-federated-poc branch September 5, 2024 15:13
rchangy pushed a commit to rchangy/Gaffer that referenced this pull request Sep 7, 2024
* basic add graph handler

* support for federated specific ops

* update testing for operation

* test tweaks

* spotless

* address comments
@tb06904 tb06904 added this to the 2.4.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an AddGraph operation for the simple federated POC
3 participants