-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3277: Add custom GafferPop Vertex Step #3278
Conversation
Add a fold step before each vertex step to collect all vertex ids so the input to the new VertexStep is a list rather than single ids. This means we can do a single Gaffer query for all ids. Note: input seeds are essentially deduped so expected output may change
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3278 +/- ##
=============================================
+ Coverage 67.66% 67.73% +0.07%
Complexity 2594 2594
=============================================
Files 942 945 +3
Lines 30070 30148 +78
Branches 3321 3328 +7
=============================================
+ Hits 20346 20421 +75
- Misses 8262 8263 +1
- Partials 1462 1464 +2 ☔ View full report in Codecov by Sentry. |
...hq/gaffer/tinkerpop/process/traversal/strategy/optimisation/GafferPopVertexStepStrategy.java
Show resolved
Hide resolved
...inkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/process/traversal/step/LazyFoldStep.java
Outdated
Show resolved
Hide resolved
...c/main/java/uk/gov/gchq/gaffer/tinkerpop/process/traversal/step/GafferPopListVertexStep.java
Outdated
Show resolved
Hide resolved
|
Add a fold step before each vertex step to collect all vertex ids so the input to the new VertexStep is a list rather than single ids. This means we can do a single Gaffer query for all ids.
Note: input seeds are essentially deduped so expected output may change
Related issue