Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3277: Add custom GafferPop Vertex Step #3278

Merged
merged 13 commits into from
Sep 12, 2024

Conversation

p29876
Copy link
Member

@p29876 p29876 commented Sep 3, 2024

Add a fold step before each vertex step to collect all vertex ids so the input to the new VertexStep is a list rather than single ids. This means we can do a single Gaffer query for all ids.

Note: input seeds are essentially deduped so expected output may change

Related issue

Add a fold step before each vertex step to collect all vertex ids
so the input to the new VertexStep is a list rather than single ids.
This means we can do a single Gaffer query for all ids.

Note: input seeds are essentially deduped so expected output may change
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (ce06bdf) to head (1689eab).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...tinkerpop/process/traversal/step/LazyFoldStep.java 83.33% 1 Missing and 1 partial ⚠️
...op/process/traversal/step/GafferPopVertexStep.java 98.03% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3278      +/-   ##
=============================================
+ Coverage      67.66%   67.73%   +0.07%     
  Complexity      2594     2594              
=============================================
  Files            942      945       +3     
  Lines          30070    30148      +78     
  Branches        3321     3328       +7     
=============================================
+ Hits           20346    20421      +75     
- Misses          8262     8263       +1     
- Partials        1462     1464       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p29876 p29876 marked this pull request as ready for review September 5, 2024 14:36
tb06904
tb06904 previously approved these changes Sep 6, 2024
cn337131
cn337131 previously approved these changes Sep 9, 2024
wb36499
wb36499 previously approved these changes Sep 9, 2024
@p29876 p29876 dismissed stale reviews from wb36499, cn337131, and tb06904 via 8cfaf4a September 9, 2024 15:17
@tb06904 tb06904 added enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module labels Sep 10, 2024
@tb06904 tb06904 added this to the 2.3.1 milestone Sep 10, 2024
Copy link

@wb36499 wb36499 merged commit 58ad080 into develop Sep 12, 2024
28 checks passed
@wb36499 wb36499 deleted the gh-3277-gafferpop-custom-vertex-step branch September 12, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GafferPop should 'squash' GetElements Operations
4 participants