Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3270: Make DeleteAllData a core operation #3271

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Aug 22, 2024

The operation DeleteAllData previously had to be added to the operationsdeclarations.json to be available, and this was only in Accumulo Stores. This work adds the operation to all stores and enables it for any graph as otherwise you must restart the graph to add this to the operationdeclarations file for it to be available.

Also addresses some technical debt in the MapStore.

Related issue

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (75c0d07) to head (83c0aa3).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ore/SingleUseMapStoreWithoutVisibilitySupport.java 0.00% 3 Missing ⚠️
...k/gov/gchq/gaffer/mapstore/multimap/MapOfSets.java 0.00% 1 Missing ⚠️
...java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3271      +/-   ##
=============================================
+ Coverage      67.53%   67.55%   +0.02%     
- Complexity      2591     2592       +1     
=============================================
  Files            926      927       +1     
  Lines          29776    29791      +15     
  Branches        3289     3289              
=============================================
+ Hits           20108    20125      +17     
+ Misses          8220     8219       -1     
+ Partials        1448     1447       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cn337131 cn337131 marked this pull request as ready for review August 22, 2024 15:38
@cn337131 cn337131 added this to the 2.3.1 milestone Aug 23, 2024
@cn337131 cn337131 added the enhancement Improvement to existing functionality/feature label Aug 23, 2024
Copy link

@wb36499 wb36499 merged commit 4e15ae1 into develop Aug 29, 2024
26 checks passed
@wb36499 wb36499 deleted the gh-3270-make-deletealldata-a-core-operation branch August 29, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DeleteAllData a core operation
4 participants