Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Gremlin not reuse Accumulo Iterators #3334

Closed
tb06904 opened this issue Nov 18, 2024 · 0 comments · Fixed by #3335
Closed

Make Gremlin not reuse Accumulo Iterators #3334

tb06904 opened this issue Nov 18, 2024 · 0 comments · Fixed by #3335
Labels
bug Confirmed or suspected bug
Milestone
2.4.0

Comments

@tb06904
Copy link
Member

tb06904 commented Nov 18, 2024

Describe the bug
Gremlin currently reuses the iterator passed back from Gaffer, this can cause performance issues when on Accumulo

** Suggested Fix **
Buffer the results to a Set first before using in Gafferpop this should hopefully aid with performance.
@tb06904 tb06904 added the bug Confirmed or suspected bug label Nov 18, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Nov 18, 2024
@tb06904 tb06904 linked a pull request Nov 18, 2024 that will close this issue
Gh-3334: Fix Gremlin Reusing Accumulo Iterators #3335
Merged
@github-actions github-actions bot mentioned this issue Nov 18, 2024
Merged
wb36499 added a commit that referenced this issue Nov 19, 2024
@wb36499
Merge branch 'develop' into gh-3334-make-gremlin-not-reuse-accumulo-i…
6eda5f4 
…terators
wb36499 pushed a commit that referenced this issue Nov 21, 2024
@tb06904
Gh-3334: Fix Gremlin Reusing Accumulo Iterators (#3335)
3b93f97 
* move to set where applicable

* update test

* Fix gremlin select step

* remove  deprecated parameter

* use safe add of labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed or suspected bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Gh-3334: Fix Gremlin Reusing Accumulo Iterators gchq/Gaffer
1 participant
@tb06904