Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Road traffic demo REST port is not changed by POM property #3185

Closed
GCHQDeveloper314 opened this issue Apr 2, 2024 · 0 comments · Fixed by #3186
Closed

Road traffic demo REST port is not changed by POM property #3185

GCHQDeveloper314 opened this issue Apr 2, 2024 · 0 comments · Fixed by #3186
Assignees
@GCHQDeveloper314
Labels
bug Confirmed or suspected bug
Milestone
v2.2.1

Comments

@GCHQDeveloper314
Copy link
Member

Describe the bug
The road-traffic-demo POM contains a property for configuring the port to use for Gaffer's REST API.

Gaffer/example/road-traffic/road-traffic-demo/pom.xml

Line 32 in 7a34d83

<standalone-port>8080</standalone-port>

However, changing this property doesn't in fact change the port used.

To Reproduce
Steps to reproduce the behaviour:

  1. Edit the port used in the POM or override the POM property manually.
  2. Run the demo using mvn install -Proad-traffic-demo -pl :road-traffic-demo.
  3. The REST API will start using port 8080, and not the standalone-port value.

Expected behaviour
Setting the standalone-port property value will set the REST API port used when the demo is run.
@GCHQDeveloper314 GCHQDeveloper314 added the bug Confirmed or suspected bug label Apr 2, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.3.0 milestone Apr 2, 2024
@GCHQDeveloper314 GCHQDeveloper314 self-assigned this Apr 2, 2024
@github-actions github-actions bot mentioned this issue Apr 2, 2024
Merged
GCHQDeveloper314 added a commit that referenced this issue Apr 3, 2024
@GCHQDeveloper314
Gh-3185: Road traffic demo REST port is not changed by POM property (#…
669c98b 
…3186)

* Fix properties tag
Needs to be nesting within <configuration>
@GCHQDeveloper314 GCHQDeveloper314 modified the milestones: v2.3.0, v2.2.1 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDeveloper314 GCHQDeveloper314

Labels
bug Confirmed or suspected bug
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging a pull request may close this issue.

Gh-3185: Road traffic demo REST port is not changed by POM property gchq/Gaffer
1 participant
@GCHQDeveloper314