Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Test Coverage for GafferPopEdge #3069

Closed
l46978 opened this issue Nov 7, 2023 · 0 comments · Fixed by #3071
Closed

Improve Test Coverage for GafferPopEdge #3069

l46978 opened this issue Nov 7, 2023 · 0 comments · Fixed by #3071
Assignees
@l46978
Labels
enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.1.0

Comments

@l46978
Copy link
Member

l46978 commented Nov 7, 2023

Adding testing to Tinkerpop work to improve coverage - works to help complete #2990.
@l46978 l46978 added the tinkerpop Specific to/touches the tinkerpop module label Nov 7, 2023
@l46978 l46978 self-assigned this Nov 7, 2023
@l46978 l46978 changed the title Improve Test COverafe for GafferPopEdge Improve Test Coverage for GafferPopEdge Nov 7, 2023
@l46978 l46978 linked a pull request Nov 7, 2023 that will close this issue
Gh-3069: Improve test coverage for GafferPopEdge.java #3071
Merged
@github-actions github-actions bot mentioned this issue Nov 7, 2023
Merged
t92549 added a commit that referenced this issue Nov 13, 2023
@t92549
Merge branch 'develop' into gh-3069-improve-test-coverage-for-gafferp…
f72ebd4 
…opedge
t92549 added a commit that referenced this issue Nov 13, 2023
@l46978 @t92549
Gh-3069: Improve test coverage for GafferPopEdge.java (#3071)
845e288 
* Added more tests to improve coverage

* Removed unnecessary check on vertex

* Used containsExactly

* Added static variables

* Added test for when Vertex obj is passed to GafferPopEdge

* Corrected variables

* Reverted Pom changes

* Reverted Pom changes

* Reverted GafferPopEdge.java

---------

Co-authored-by: t92549 <[email protected]>
@t92549 t92549 added this to the v2.1.0 milestone Nov 13, 2023
@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l46978 l46978

Labels
enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Gh-3069: Improve test coverage for GafferPopEdge.java gchq/Gaffer
2 participants
@t92549 @l46978