Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinkerpop module delays a full build #3009

Closed
GCHQDeveloper314 opened this issue Jul 20, 2023 · 0 comments · Fixed by #3010
Closed

Tinkerpop module delays a full build #3009

GCHQDeveloper314 opened this issue Jul 20, 2023 · 0 comments · Fixed by #3010
Assignees
Labels
bug Confirmed or suspected bug
Milestone

Comments

@GCHQDeveloper314
Copy link
Member

Describe the bug
When running a full build of Gaffer the configuration for the tinkerpop Maven module causes a forked build of all the dependencies of this module to be built, even though they have already been built prior. This is caused by the assembly plugin using the wrong goal, it should use the single goal.

To Reproduce
Steps to reproduce the behavior:

  1. Run mvn clean install -Pquick
  2. The build will take a long time on the tinkerpop module and "forking" messages will be seen for other modules being rebuilt.

Expected behavior
The tinkerpop module should not take significantly longer than the other modules and there should be no forking.

Additional context
The default maven-assembly-plugin version is used, which is old and so this should also be upgraded.

@GCHQDeveloper314 GCHQDeveloper314 added the bug Confirmed or suspected bug label Jul 20, 2023
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.1.0 milestone Jul 20, 2023
@GCHQDeveloper314 GCHQDeveloper314 self-assigned this Jul 20, 2023
GCHQDeveloper314 added a commit that referenced this issue Jul 20, 2023
* Do not use forking goal

* Ensure newest assembly plugin version is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant